-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugins in HLTrigger/JetMET #10582
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X. Fix plugins in HLTrigger/JetMET It involves the following packages: HLTrigger/JetMET @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
@cmsbuild, please test |
Fix plugins in HLTrigger/JetMET
The tests are being triggered in jenkins. |
Pull request #10582 was updated. @perrotta, @cmsbuild, @danduggan, @Martin-Grunewald, @deguio, @fwyzard can you please check and sign again. |
@smuzaffar @davidlange6 Maybe we should start scanning lib*.so for plugins and issuing errors if they are found? |
I agree. Is there any symbol which one can look in the lib*.so? On 8/5/2015 2:54 PM, Chris Jones wrote:
|
@smuzaffar I don't believe a symbol exists. It is possible to make a simple executable that would return a particular value if a plugin was found in a loaded library. |
Comparison is ready There are some workflows for which there are errors in the baseline: |
Comparison is ready There are some workflows for which there are errors in the baseline: |
move plugins into plugins directory (with other plugins) as not to rely on luck that exactly one plugin library links against HLTrigger/JetMET/src